chore: update PyPi metadata #8971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8971 +/- ##
==========================================
+ Coverage 47.34% 47.36% +0.01%
==========================================
Files 1162 1162
Lines 176133 176133
Branches 2237 2237
==========================================
+ Hits 83396 83422 +26
+ Misses 92579 92553 -26
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Failing Flake CI... Fixed |
sirredbeard
force-pushed
the
update_pypi_listing
branch
from
64e949a
to
4af4dfc
Compare
wes-turner
reviewed
Mar 7, 2024
| license="Apache License 2.0", | ||
| classifiers=["License :: OSI Approved :: Apache Software License"], | ||
| # Use find_namespace_packages because it will include data-only packages (that is, directories | ||
| # containing only non-python files, like our gcp terraform directory). | ||
| packages=setuptools.find_namespace_packages(include=["determined*"]), | ||
| # Technically, we haven't supported 3.6 or tested against it since it went EOL. But some users | ||
| # are still using it successfully so there's hardly a point in breaking them. | ||
| python_requires=">=3.6", | ||
| python_requires=">=3.8", |
There was a problem hiding this comment.
Updating to 3.7 can be done without checking with anyone (it already needs at least 3.7 to run). I'd like it if we could say 3.8, since that's the oldest version we test against, but I think we should check with Product and someone who can represent current customers to see if it'll break anyone's workflow.
4 tasks
wes-turner
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates determined pip package metadata in PyPi.
DET-10187
Test Plan
Unsure how to test without deploying a new version.