chore: add multirm router layer to rm module #8963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinaecalderon
force-pushed
the
carolinac/revert-rm-changes
branch
from
5cfdbd5
to
36f23b3
Compare
carolinaecalderon
force-pushed
the
carolinac/add-multirm-router-layer
branch
from
ba454ee
to
8d0b622
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8963 +/- ##
=======================================
Coverage 47.48% 47.49%
=======================================
Files 1168 1167 -1
Lines 176302 176298 -4
Branches 2353 2354 +1
=======================================
+ Hits 83717 83730 +13
+ Misses 92427 92410 -17
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
carolinaecalderon
force-pushed
the
carolinac/revert-rm-changes
branch
from
36f23b3
to
4ce070a
Compare
carolinaecalderon
force-pushed
the
carolinac/add-multirm-router-layer
branch
3 times, most recently
from
afbb0c5
to
9aaec35
Compare
carolinaecalderon
requested review from
kkunapuli,
stoksc and
NicholasBlaskey
and removed request for
a team
stoksc
reviewed
Mar 6, 2024
| @@ -39,14 +37,14 @@ type ResourceManager interface { | |||
| ) (model.TaskContainerDefaultsConfig, error) | |||
|
|
|||
| // Job queue | |||
| GetJobQ(sproto.GetJobQ) (map[model.JobID]*sproto.RMJobInfo, error) | |||
| GetJobQ(string) (map[model.JobID]*sproto.RMJobInfo, error) | |||
There was a problem hiding this comment.
i'd like for us to type resource pools at some point
There was a problem hiding this comment.
(type ResourcePoolName string)
stoksc
approved these changes
Mar 6, 2024
| func ErrRPNotDefined(rp string) error { | ||
| return fmt.Errorf("could not find resource pool %s", rp) | ||
| } | ||
|
|
There was a problem hiding this comment.
i'm trusting this is unchanged since it was last landed
There was a problem hiding this comment.
I had to change the signatures to not take in a RM name, and similarly, in getRM, I removed references to RM name
carolinaecalderon
force-pushed
the
carolinac/add-multirm-router-layer
branch
from
9aaec35
to
6d00842
Compare
carolinaecalderon
force-pushed
the
carolinac/add-multirm-router-layer
branch
from
6d00842
to
570f9e1
Compare
✅ Deploy Preview for determined-ui canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the multirm module back in (from #8857 ) , but look up the right resource manager from the globally unique resource pool name provided.
Also delete sproto messages that wrap under 3 variables, replace this directly with the variables in the RM interface. This reduces bloat in the repo, as sproto message wrappers are remnants of the actor system.
Test Plan
See multirm_intg_test.go
Commentary (optional)
Since I'm making changes to the signatures of methods in the RM interface, there are a lot of one-line changes in the repo. I recommend looking at the
resource_manager_iface.go, and themultirmmodule.There's no check if there are multiple same-named resource pools at this level -- that will be the responsibility of the config to check
Checklist
docs/release-notes/.See Release Note for details.
Ticket
RM-73