Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix pre_publish check #8957

Merged
merged 1 commit into from
Mar 5, 2024
Merged

docs: fix pre_publish check #8957

merged 1 commit into from
Mar 5, 2024

Conversation

MikhailKardash
Copy link
Contributor

@MikhailKardash MikhailKardash commented Mar 5, 2024

Description

make sure attributions.rst exists before publish-check.

Test Plan

cd docs
make clean
make publish-check

@cla-bot cla-bot bot added the cla-signed label Mar 5, 2024
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@determined-ci determined-ci requested a review from a team March 5, 2024 20:58
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Mar 5, 2024
Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit a87b3c6
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65e78758295722000965d7ac

@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@MikhailKardash MikhailKardash merged commit c7e5d43 into main Mar 5, 2024
76 of 88 checks passed
@MikhailKardash MikhailKardash deleted the publish_check_fix branch March 5, 2024 21:13
@julian-determined-ai julian-determined-ai added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Mar 5, 2024
dai-release bot pushed a commit that referenced this pull request Mar 5, 2024
* fix publish-check in docs MakeFile

(cherry picked from commit c7e5d43)
Copy link
Member

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

julian-determined-ai pushed a commit that referenced this pull request Mar 5, 2024
* fix publish-check in docs MakeFile

(cherry picked from commit c7e5d43)
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
* fix publish-check in docs MakeFile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants