-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix pre_publish check #8957
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docsite preview being generated for this PR. |
✅ Deploy Preview for determined-ui canceled.
|
Docsite preview being generated for this PR. |
julian-determined-ai
approved these changes
Mar 5, 2024
julian-determined-ai
added
the
to-cherry-pick
Pull requests that need to be cherry-picked into the current release
label
Mar 5, 2024
dai-release bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
* fix publish-check in docs MakeFile (cherry picked from commit c7e5d43)
tara-det-ai
reviewed
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
julian-determined-ai
pushed a commit
that referenced
this pull request
Mar 5, 2024
* fix publish-check in docs MakeFile (cherry picked from commit c7e5d43)
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
* fix publish-check in docs MakeFile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla-signed
documentation
Improvements or additions to documentation
to-cherry-pick
Pull requests that need to be cherry-picked into the current release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make sure
attributions.rst
exists beforepublish-check
.Test Plan
cd docs
make clean
make publish-check