-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow k8srm to connect with a kubeconfig #8953
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8953 +/- ##
==========================================
+ Coverage 47.35% 47.37% +0.01%
==========================================
Files 1162 1162
Lines 176133 176129 -4
Branches 2237 2236 -1
==========================================
+ Hits 83402 83435 +33
+ Misses 92573 92536 -37
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I'll update the docs tomorrow, and add tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works on my machine, just one change needed in the devcluster.yaml
39c3603
to
e302694
Compare
e302694
to
5c49233
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work Bradley! LGTM
running k8s cpu tests then merging. codecov is a bit obnoxious, that I get knocked for adding a config to a bunch of untested files even though the meat of the change is tested. |
Allow users to configure the k8s REST client using by Determined by supplying us a kubeconfig. Promote the master ip and port fields to public to allow users to configure routing masters outside the cluster the jobs are running in (or otherwise explicitly configure routing). Remove _creds_dir and its documentation in favor of local devclusters using the byo kubeconfig route instead.
Description
Allow users to configure the k8s REST client from a kubeconfig. Promote the master ip/port fields to allow
jobs talking to masters outside the cluster they are in to find the master. Remove _creds_dir and its documentation
and upgrade the local
devcluster
route byo kubeconfig instead.Test Plan
Follow the instructions for the dev flow in
tools/k8s
. Do they work?Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket
RM-15