Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add resource manager name/metadata to resourcepoolv1 proto [RM-12] #8948

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

NicholasBlaskey
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey commented Mar 4, 2024

Description

Adds resource manager name and metadata to resource pool proto object.

I'll make a slurm PR right now

Test Plan

Unit tests should cover it

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

RM-12

Copy link

netlify bot commented Mar 4, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit cf08cbf
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65e63ad38f4e0f0008eca9e6
😎 Deploy Preview https://deploy-preview-8948--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 47.34%. Comparing base (a5b425a) to head (cf08cbf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8948      +/-   ##
==========================================
+ Coverage   47.27%   47.34%   +0.07%     
==========================================
  Files        1162     1162              
  Lines      176114   176132      +18     
  Branches     2235     2236       +1     
==========================================
+ Hits        83259    83395     +136     
+ Misses      92697    92579     -118     
  Partials      158      158              
Flag Coverage Δ
backend 42.63% <100.00%> (+0.29%) ⬆️
harness 63.94% <0.00%> (-0.01%) ⬇️
web 42.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ster/internal/rm/agentrm/agent_resource_manager.go 46.70% <100.00%> (+0.22%) ⬆️
...nal/rm/kubernetesrm/kubernetes_resource_manager.go 20.29% <100.00%> (+20.29%) ⬆️
webui/react/src/services/api-ts-sdk/api.ts 47.64% <100.00%> (+0.01%) ⬆️
harness/determined/common/api/bindings.py 40.23% <0.00%> (-0.01%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Contributor

@carolinaecalderon carolinaecalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicholasBlaskey NicholasBlaskey merged commit e8b0165 into main Mar 4, 2024
73 of 85 checks passed
@NicholasBlaskey NicholasBlaskey deleted the rm_name_and_metadata branch March 4, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants