chore: amend contributing doc to point to correct make rule #8947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesse-amano-hpe
changed the title
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8947 +/- ##
=======================================
Coverage 47.27% 47.27%
=======================================
Files 1162 1162
Lines 176114 176114
Branches 2235 2235
=======================================
Hits 83259 83259
Misses 92697 92697
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. |
jesse-amano-hpe
changed the title
jesse-amano-hpe
force-pushed
the
jta/update-contributing-md
branch
from
4e067f6
to
4d587ac
Compare
jesse-amano-hpe
requested review from
a team and
maxrussell
and removed request for
a team
hamidzr
approved these changes
Mar 5, 2024
maxrussell
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From #2892 ,
make -C tools runis no longer a supported command. Users should rundevcluster [-c CONFIG_PATH]ormake devclusterinstead.Test Plan
N/A
Checklist
User-facing API changes need the "User-facing API Change" label.Release notes should be added as a separate file underdocs/release-notes/.Licenses should be included for new code which was copied and/or modified from any external code.