Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused constant #8934

Merged
merged 1 commit into from
Mar 1, 2024
Merged

chore: remove unused constant #8934

merged 1 commit into from
Mar 1, 2024

Conversation

wes-turner
Copy link
Contributor

@wes-turner wes-turner commented Mar 1, 2024

HOROVOD_GLOO_RENDEZVOUS_PORT is unused.

#2771 was the PR that removed its only use. Once, it was passed directly to horovod.

Description

Test Plan

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@wes-turner wes-turner requested a review from a team as a code owner March 1, 2024 20:22
@cla-bot cla-bot bot added the cla-signed label Mar 1, 2024
@wes-turner wes-turner requested review from rb-determined-ai and removed request for tayritenour March 1, 2024 20:23
Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit ef0d13a
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65e239196ffe8d0008f94687

Copy link
Member

@rb-determined-ai rb-determined-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look at you go!

@wes-turner wes-turner merged commit 2dfc4f2 into main Mar 1, 2024
71 of 84 checks passed
@wes-turner wes-turner deleted the wes/no-gloo-port branch March 1, 2024 20:42
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
HOROVOD_GLOO_RENDEZVOUS_PORT is unused.

#2771 was the PR that removed its only use. Once, it was passed directly to horovod.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants