Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change go 1.22 to 1.22.0 in go.mod #8929

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

azhou-determined
Copy link
Contributor

@azhou-determined azhou-determined commented Feb 29, 2024

Description

on macOS/darwin, go doesn't run after updating to 1.22.

go: downloading go1.22 (darwin/amd64)
go: download go1.22 for darwin/amd64: toolchain not available

per this github issue, changing to 1.22.0 fixes the issue.

Test Plan

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 265a6e3
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65e0ee92ec533f0008eb97b2

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.19%. Comparing base (63adae5) to head (265a6e3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8929   +/-   ##
=======================================
  Coverage   47.19%   47.19%           
=======================================
  Files        1155     1155           
  Lines      175116   175116           
  Branches     2237     2237           
=======================================
  Hits        82648    82648           
  Misses      92310    92310           
  Partials      158      158           
Flag Coverage Δ
backend 42.37% <ø> (ø)
harness 63.71% <ø> (ø)
web 42.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@azhou-determined azhou-determined merged commit 225dba3 into main Feb 29, 2024
78 of 90 checks passed
@azhou-determined azhou-determined deleted the go-1.22-version-fix branch February 29, 2024 22:33
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants