fix: canonicalize master urls shim code #8919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rb-determined-ai
added
the
to-cherry-pick
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8919 +/- ##
==========================================
- Coverage 48.42% 44.48% -3.94%
==========================================
Files 743 715 -28
Lines 136157 134422 -1735
Branches 2235 2236 +1
==========================================
- Hits 65929 59804 -6125
- Misses 70070 74460 +4390
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Since we are now stricter about what is a valid master_url (rejecting
some silly things like usernames or fragments that make no sense in the
url), we must take special care when reading auth.json written by old
versions of our code.
Without this fix, users who mistakenly logged in in the past with
DET_USER=http://user@mymaster
would have a broken CLI because the shim code would puke every time it
tried to upgrade auth.json from v1 to v2.
rb-determined-ai
force-pushed
the
rb/master-url
branch
from
4a84dac
to
befeda7
Compare
|
only failures look like known flakes, I'm force-landing this. |
dai-release bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
Since we are now stricter about what is a valid master_url (rejecting
some silly things like usernames or fragments that make no sense in the
url), we must take special care when reading auth.json written by old
versions of our code.
Without this fix, users who mistakenly logged in in the past with
DET_USER=http://user@mymaster
would have a broken CLI because the shim code would puke every time it
tried to upgrade auth.json from v1 to v2.
(cherry picked from commit 3a3b668)
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
Since we are now stricter about what is a valid master_url (rejecting
some silly things like usernames or fragments that make no sense in the
url), we must take special care when reading auth.json written by old
versions of our code.
Without this fix, users who mistakenly logged in in the past with
DET_USER=http://user@mymaster
would have a broken CLI because the shim code would puke every time it
tried to upgrade auth.json from v1 to v2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are now stricter about what is a valid master_url (rejecting some silly things like usernames or fragments that make no sense in the url), we must take special care when reading auth.json written by old versions of our code.
Without this fix, users who mistakenly logged in in the past with
would have a broken CLI because the shim code would puke every time it tried to upgrade auth.json from v1 to v2.