Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup stray comments #8889

Merged
merged 1 commit into from
Feb 26, 2024
Merged

chore: cleanup stray comments #8889

merged 1 commit into from
Feb 26, 2024

Conversation

rb-determined-ai
Copy link
Member

No description provided.

Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 48eaee1
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65dcc1fdafa134000811233b

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.55%. Comparing base (f37bc3e) to head (48eaee1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8889   +/-   ##
=======================================
  Coverage   47.54%   47.55%           
=======================================
  Files        1065     1065           
  Lines      170217   170217           
  Branches     2243     2243           
=======================================
+ Hits        80935    80940    +5     
+ Misses      89124    89119    -5     
  Partials      158      158           
Flag Coverage Δ
backend 43.35% <ø> (+<0.01%) ⬆️
harness 63.82% <ø> (+<0.01%) ⬆️
web 42.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/_trial_controller.py 78.18% <ø> (ø)
harness/determined/pytorch/_trainer.py 54.80% <ø> (ø)

... and 3 files with indirect coverage changes

@rb-determined-ai rb-determined-ai merged commit b47b477 into main Feb 26, 2024
75 of 89 checks passed
@rb-determined-ai rb-determined-ai deleted the rb/cleanup branch February 26, 2024 18:30
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants