Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete unused functions [RM-41] #8888

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

kkunapuli
Copy link
Contributor

@kkunapuli kkunapuli commented Feb 26, 2024

Description

chore: delete unused functions RM-41

CheckExperimentExists and CheckTrialExists are not used in the codebase. Rather than bunifying them, we can delete them; they can be added back in if we ever need them

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

RM-41

@cla-bot cla-bot bot added the cla-signed label Feb 26, 2024
Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 0d1812f
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65dcbca6dc03e00008cf6268

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.55%. Comparing base (7bb9dbc) to head (0d1812f).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8888   +/-   ##
=======================================
  Coverage   47.55%   47.55%           
=======================================
  Files        1065     1065           
  Lines      170222   170204   -18     
  Branches     2243     2243           
=======================================
+ Hits        80942    80947    +5     
+ Misses      89122    89099   -23     
  Partials      158      158           
Flag Coverage Δ
backend 43.37% <ø> (+0.02%) ⬆️
harness 63.82% <ø> (+<0.01%) ⬆️
web 42.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/db/postgres_experiments.go 54.31% <ø> (+1.32%) ⬆️

... and 3 files with indirect coverage changes

@kkunapuli kkunapuli marked this pull request as ready for review February 26, 2024 16:49
@kkunapuli kkunapuli requested a review from a team as a code owner February 26, 2024 16:49
Copy link
Contributor

@carolinaecalderon carolinaecalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@kkunapuli kkunapuli merged commit 2689b0b into main Feb 27, 2024
81 of 93 checks passed
@kkunapuli kkunapuli deleted the kunapuli/delete-unused-exists branch February 27, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants