Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert add allocation info for cluster ui [DET-10018] #8876

Merged

Conversation

jgongd
Copy link
Contributor

@jgongd jgongd commented Feb 23, 2024

Reverts #8616

@jgongd jgongd requested a review from a team as a code owner February 23, 2024 15:22
Copy link

cla-bot bot commented Feb 23, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @jgongd on file. In order for us to review and merge your code, please start the CLA process at https://determined.ai/cla.

After we approve your CLA, we will update the contributors list (private) and comment @cla-bot[bot] check to rerun the check.

Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 6ff6152
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65d8bd5445dbb10008e8ebbe

@jgongd jgongd changed the title Revert "chore: add allocation info for cluster ui [DET-10018]" chore: revert add allocation info for cluster ui [DET-10018] Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 56.52174% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 47.48%. Comparing base (72d54be) to head (6ff6152).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8876      +/-   ##
==========================================
- Coverage   47.49%   47.48%   -0.01%     
==========================================
  Files        1065     1065              
  Lines      170236   170160      -76     
  Branches     2241     2243       +2     
==========================================
- Hits        80847    80807      -40     
+ Misses      89231    89195      -36     
  Partials      158      158              
Flag Coverage Δ
backend 43.05% <56.52%> (-0.01%) ⬇️
harness 63.82% <ø> (+0.02%) ⬆️
web 42.53% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/common/api/bindings.py 40.34% <ø> (+0.05%) ⬆️
master/internal/rm/agentrm/resources.go 0.00% <ø> (ø)
master/internal/rm/kubernetesrm/pod.go 81.72% <100.00%> (-0.50%) ⬇️
master/pkg/model/agent.go 0.00% <ø> (ø)
webui/react/src/services/api-ts-sdk/api.ts 47.55% <ø> (-0.03%) ⬇️
master/internal/rm/agentrm/agent_state.go 83.84% <80.00%> (+1.41%) ⬆️
master/pkg/model/task.go 15.26% <0.00%> (+0.15%) ⬆️
master/internal/rm/kubernetesrm/pods.go 15.70% <38.46%> (-0.64%) ⬇️

... and 2 files with indirect coverage changes

@jgongd jgongd force-pushed the revert-8616-jgong/add-allocation-info-to-get-agent-endpoint branch from 9e2ff04 to 6ff6152 Compare February 23, 2024 15:44
Copy link

cla-bot bot commented Feb 23, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @jgongd on file. In order for us to review and merge your code, please start the CLA process at https://determined.ai/cla.

After we approve your CLA, we will update the contributors list (private) and comment @cla-bot[bot] check to rerun the check.

@jgongd jgongd merged commit f101f3d into main Feb 23, 2024
71 of 86 checks passed
@jgongd jgongd deleted the revert-8616-jgong/add-allocation-info-to-get-agent-endpoint branch February 23, 2024 16:06
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants