fix: allow experiments to configure k8s sidecars #8854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
rb-determined-ai
force-pushed
the
rb/expconf
branch
from
c6b2cf7
to
39f0ecc
Compare
ioga
approved these changes
Feb 16, 2024
|
I suppose an RP test for this is "run an experiment with a sidecar", |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8854 +/- ##
==========================================
- Coverage 47.58% 47.58% -0.01%
==========================================
Files 1068 1068
Lines 170311 170311
Branches 2243 2243
==========================================
- Hits 81043 81037 -6
- Misses 89110 89116 +6
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rb-determined-ai
force-pushed
the
rb/expconf
branch
from
39f0ecc
to
1065c62
Compare
|
oops, almost forgot to |
stoksc
approved these changes
Feb 16, 2024
This turns out to be my regression from Jan 2021 when expconf first landed. Also, we might as well resurrect the detailed explanations that used to be in extensions.py, and which were still cited by the go files, even though the python code was deleted a long time ago.
rb-determined-ai
force-pushed
the
rb/expconf
branch
from
1065c62
to
ed8daa5
Compare
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
This turns out to be my regression from Jan 2021 when expconf first landed. Also, we might as well resurrect the detailed explanations that used to be in extensions.py, and which were still cited by the go files, even though the python code was deleted a long time ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns out to be my regression from Jan 2021 when expconf first landed.
Also, we might as well resurrect the detailed explanations that used to be in extensions.py, and which were still cited by the go files, even though the python code was deleted a long time ago.
Test Plan