Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: agent state wasn't getting deleted and logged error #8838

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

NicholasBlaskey
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey commented Feb 13, 2024

Description

clearAgent state was broken. Add a test and fix it.

Test Plan

intg test

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Feb 13, 2024
Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit a91d200
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65cbc9c1efd32c0007a11162

@NicholasBlaskey NicholasBlaskey marked this pull request as ready for review February 13, 2024 17:04
@NicholasBlaskey NicholasBlaskey requested a review from a team as a code owner February 13, 2024 17:04
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (393cfde) 47.68% compared to head (a91d200) 47.69%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8838      +/-   ##
==========================================
+ Coverage   47.68%   47.69%   +0.01%     
==========================================
  Files        1046     1065      +19     
  Lines      167950   169614    +1664     
  Branches     2240     2238       -2     
==========================================
+ Hits        80079    80901     +822     
- Misses      87713    88555     +842     
  Partials      158      158              
Flag Coverage Δ
backend 43.47% <80.00%> (+0.28%) ⬆️
harness 64.11% <ø> (ø)
web 42.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/rm/agentrm/agent_state.go 83.84% <80.00%> (-0.15%) ⬇️

... and 23 files with indirect coverage changes

Copy link
Contributor

@stoksc stoksc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@NicholasBlaskey NicholasBlaskey enabled auto-merge (squash) February 13, 2024 19:58
@NicholasBlaskey NicholasBlaskey merged commit aa98d82 into main Feb 13, 2024
69 of 84 checks passed
@NicholasBlaskey NicholasBlaskey deleted the fix_agent_state_not_getting_deleted branch February 13, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants