-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix performance feature branch using wrong db #8835
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8835 +/- ##
==========================================
- Coverage 47.69% 47.69% -0.01%
==========================================
Files 1065 1065
Lines 169636 169636
Branches 2240 2240
==========================================
- Hits 80904 80902 -2
- Misses 88574 88576 +2
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. |
djanicekpach
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
carolinaecalderon
pushed a commit
that referenced
this pull request
Feb 19, 2024
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes two issues with performance tests.
The feature branch was accidentally using the main database because of a bug.
Sometimes the feature branch would fail and not run the db cleanup command.
Test Plan
Run a migration on a perf feature branch and check main database isn't updated
Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket