-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup the last traces of experiment git fields. [MD-258] #8830
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8830 +/- ##
=======================================
Coverage 47.59% 47.59%
=======================================
Files 1068 1068
Lines 170281 170200 -81
Branches 2238 2240 +2
=======================================
- Hits 81039 81002 -37
+ Misses 89084 89040 -44
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d521c42
to
f6256bb
Compare
Description
Unused git fields on experiment object got removed in #8639 but they were still present in protos and CLI code. Remove them.
Test Plan
N/A: removing dead code.
Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket