Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup the last traces of experiment git fields. [MD-258] #8830

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

ioga
Copy link
Contributor

@ioga ioga commented Feb 12, 2024

Description

Unused git fields on experiment object got removed in #8639 but they were still present in protos and CLI code. Remove them.

Test Plan

N/A: removing dead code.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@ioga ioga requested review from a team as code owners February 12, 2024 20:15
@ioga ioga requested a review from wes-turner February 12, 2024 20:15
@cla-bot cla-bot bot added the cla-signed label Feb 12, 2024
Copy link

netlify bot commented Feb 12, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit f6256bb
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65cbe8be3ce1aa0008dbdf74
😎 Deploy Preview https://deploy-preview-8830--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca80022) 47.59% compared to head (f6256bb) 47.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8830   +/-   ##
=======================================
  Coverage   47.59%   47.59%           
=======================================
  Files        1068     1068           
  Lines      170281   170200   -81     
  Branches     2238     2240    +2     
=======================================
- Hits        81039    81002   -37     
+ Misses      89084    89040   -44     
  Partials      158      158           
Flag Coverage Δ
backend 43.06% <ø> (-0.01%) ⬇️
harness 64.17% <100.00%> (+0.06%) ⬆️
web 42.54% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/cli/experiment.py 23.98% <100.00%> (+0.75%) ⬆️
harness/determined/common/api/bindings.py 40.39% <ø> (-0.01%) ⬇️
master/pkg/model/experiment.go 13.63% <ø> (ø)
webui/react/src/services/api-ts-sdk/api.ts 47.59% <ø> (-0.04%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Contributor

@carolinaecalderon carolinaecalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ioga ioga merged commit 5b2e32d into main Feb 13, 2024
73 of 86 checks passed
@ioga ioga deleted the git-fields-purge branch February 13, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants