Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle helm templating in older go template versions #8828

Merged
merged 4 commits into from
Feb 12, 2024

Conversation

tayritenour
Copy link
Contributor

@tayritenour tayritenour commented Feb 12, 2024

Description

Older versions of go template do not support short-circuiting with and. Our method of trying to safely check for versions wasn't being called correctly. More info: https://stackoverflow.com/questions/55464747/combining-two-if-conditions-into-one

Test Plan

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

Copy link

netlify bot commented Feb 12, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 248e117
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65ca70178a26e90008a8bf5d

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f300d97) 47.84% compared to head (248e117) 47.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8828      +/-   ##
==========================================
- Coverage   47.84%   47.84%   -0.01%     
==========================================
  Files        1061     1061              
  Lines      168144   168144              
  Branches     2240     2240              
==========================================
- Hits        80449    80445       -4     
- Misses      87537    87541       +4     
  Partials      158      158              
Flag Coverage Δ
backend 43.94% <ø> (-0.02%) ⬇️
harness 64.32% <ø> (ø)
web 42.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@tayritenour tayritenour requested a review from a team as a code owner February 12, 2024 18:39
@tayritenour tayritenour force-pushed the fix_helm_with_older_go_template_versions branch from 89769e1 to 4776435 Compare February 12, 2024 18:51
@tayritenour tayritenour merged commit fff85e3 into main Feb 12, 2024
76 of 91 checks passed
@tayritenour tayritenour deleted the fix_helm_with_older_go_template_versions branch February 12, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants