Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mitigate many unnecessary api calls in user management table #8816

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Feb 7, 2024

Description

WEB-1965

Test Plan

  • Check if no initial user role api calls in user tab in user management table with RBAC enabled (see WEB-1965 for more details)
  • Check if user information is correct in edit user modal and works as expected
  • Check if user can be newly created in create user modal

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Feb 7, 2024
@keita-determined keita-determined marked this pull request as ready for review February 7, 2024 23:19
Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 45d7f8e
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65c496acf84d6c00075b075d
😎 Deploy Preview https://deploy-preview-8816--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@keita-determined keita-determined requested a review from a team as a code owner February 7, 2024 23:19
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (3805ebd) 47.72% compared to head (45d7f8e) 42.73%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8816      +/-   ##
==========================================
- Coverage   47.72%   42.73%   -4.99%     
==========================================
  Files        1049      732     -317     
  Lines      167293   128617   -38676     
  Branches     2243     2238       -5     
==========================================
- Hits        79846    54970   -24876     
+ Misses      87289    73489   -13800     
  Partials      158      158              
Flag Coverage Δ
harness ?
web 42.52% <78.57%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/components/CreateUserModal.tsx 89.54% <100.00%> (+2.62%) ⬆️
webui/react/src/pages/Admin/UserManagement.tsx 83.27% <68.96%> (-0.96%) ⬇️

... and 317 files with indirect coverage changes

Copy link
Contributor

@gt2345 gt2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keita-determined keita-determined merged commit 1c3f3c4 into main Feb 8, 2024
75 of 87 checks passed
@keita-determined keita-determined deleted the fix/too-many-api-calls branch February 8, 2024 17:56
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
)

* fix: mitigate many unnecessary api calls in user management table

* fix: removed unused code

* refactor: refactor code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants