-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: improve GetExperiments + SearchExperiments counting #8801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8801 +/- ##
=======================================
Coverage 47.69% 47.69%
=======================================
Files 1065 1065
Lines 169612 169611 -1
Branches 2240 2238 -2
=======================================
+ Hits 80901 80903 +2
+ Misses 88553 88550 -3
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
New pagination count for experiments-search
|
Old pagination count for experiments-search
|
hamidzr
approved these changes
Feb 8, 2024
NicholasBlaskey
force-pushed
the
perf_improve_get_experiments
branch
from
February 13, 2024 15:18
82c66ef
to
3454217
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GetExperiments + SearchExperiments take a long time to count the experiments.
I think partly the introduction of the trials view really messed with the optimizer on this.
Test Plan
integration tests
Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket