-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fetch experiment in case config data is not contained #8789
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
8e4040e
to
95a8f70
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8789 +/- ##
===========================================
- Coverage 53.00% 42.71% -10.29%
===========================================
Files 633 732 +99
Lines 72314 128610 +56296
Branches 0 2241 +2241
===========================================
+ Hits 38331 54942 +16611
- Misses 33983 73510 +39527
- Partials 0 158 +158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given that we use this modal in the details view (where we should have the full config available), could we instead show a loader modal in the context menu that then shows the hyperparameter search modal once the experiment is fetched?
sorry, to reword, perhaps instead have the context menus in the experiment lists show a modal that just consists of a loading spinner that loads the full experiment, then passes it on to the hyperparameter search modal.
42b12b3
to
00edc6c
Compare
00edc6c
to
fb0362d
Compare
fixed |
* fix: fetch experiment in case config data is not contained * test: fix test cases * fix: minor fix * fix: get experiment in top level
Description
There is a bug after #8765
The context menu (right click menu) in the new experiment table has
Hyperparameter Search
option. When the option is clicked on the new experiment table view, the data fromexperiment-search
API does not containconfig
data since it is deprecated in #8732 and unlinked on web in #8765. Therefore, we need to fetch experiment data throughgetExperiment
API for the missingconfig
.Before this fix,
Unexpected Error
shows up after clicking context menu.Test Plan
Hyperparapeter Search
button in experiment detail pageCommentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket