fix: improve trial log request cancelling #8787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes an issue where resetting the filter settings on trials with logs that take a long time to respond (over 500 ms) can cause the catch up log request to get cancelled. To fix, we skip aborting the request when handling filter changes if the filter is being updated to an empty object. This is because the request was already reset when the filter was reset. We also ensure that old requests don't stick around by merging the outer abort controller with the one that the stream config gives us.
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8787 +/- ##
==========================================
- Coverage 47.69% 42.69% -5.01%
==========================================
Files 1049 732 -317
Lines 167230 128569 -38661
Branches 2239 2239
==========================================
- Hits 79766 54888 -24878
+ Misses 87306 73523 -13783
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ashtonG
added
the
to-cherry-pick
keita-determined
approved these changes
Feb 2, 2024
dai-release bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
this fixes an issue where resetting the filter settings on trials with logs that take a long time to respond (over 500 ms) can cause the catch up log request to get cancelled. To fix, we skip aborting the request when handling filter changes if the filter is being updated to an empty object. This is because the request was already reset when the filter was reset. We also ensure that old requests don't stick around by merging the outer abort controller with the one that the stream config gives us. (cherry picked from commit bb88b01)
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
this fixes an issue where resetting the filter settings on trials with logs that take a long time to respond (over 500 ms) can cause the catch up log request to get cancelled. To fix, we skip aborting the request when handling filter changes if the filter is being updated to an empty object. This is because the request was already reset when the filter was reset. We also ensure that old requests don't stick around by merging the outer abort controller with the one that the stream config gives us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this fixes an issue where resetting the filter settings on trials with logs that take a long time to respond (over 500 ms) can cause the catch up log request to get cancelled. To fix, we skip aborting the request when handling filter changes if the filter is being updated to an empty object. This is because the request was already reset when the filter was reset. We also ensure that old requests don't stick around by merging the outer abort controller with the one that the stream config gives us.
Test Plan
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket
WEB-1964