docs: update dependency version in contributing readme #8776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8776 +/- ##
==========================================
- Coverage 47.44% 47.44% -0.01%
==========================================
Files 1046 1046
Lines 166888 166888
Branches 2239 2239
==========================================
- Hits 79186 79184 -2
- Misses 87544 87546 +2
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. |
hamidzr
approved these changes
Jan 30, 2024
| @@ -118,7 +118,7 @@ source $HOME/.profile | |||
| cd determined | |||
| python3 -m venv $HOME/.virtualenvs/determined | |||
| . $HOME/.virtualenvs/determined/bin/activate | |||
| $HOME/.virtualenvs/determined/bin/python3.7 -m pip install --upgrade pip | |||
| $HOME/.virtualenvs/determined/bin/python3.9 -m pip install --upgrade pip | |||
There was a problem hiding this comment.
It's 3.7 (as listed). The previous instructions have users installing python 3.9 ... whichever version is used I think it should be consistent.
|
thanks for fixing these! 🚀 |
kkunapuli
deleted the
kunapuli/update-dependency-versions-contributing
branch
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Webui requires node 20.* to compile. The docs listed multiple version of python; updating it so be consistent.
Test Plan
Run
make allwith the specified dependency versions.Checklist
docs/release-notes/.See Release Note for details.