Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Text filter on ProjectMoveModal [WEB-1495] #8775

Merged
merged 1 commit into from
Jan 30, 2024
Merged

fix: Text filter on ProjectMoveModal [WEB-1495] #8775

merged 1 commit into from
Jan 30, 2024

Conversation

mapmeld
Copy link
Contributor

@mapmeld mapmeld commented Jan 30, 2024

Description

A ticket about workspaces in the ProjectMoveModal dropdown

  • appearing in alphabetic order (currently ✔️ )
  • search / autocomplete (currently ❌ )

Sets searchable text of workspaces using label={workspace.name}

The filter might have broken when we updated Typography. ExperimentMoveModal is already working

Test Plan

Open a workspace other than default (such as /det/workspaces/1486/projects)
Click the three dots menu to select "Move..."

Screen Shot 2024-01-30 at 10 45 11 AM

In the modal, test text autocomplete is case-insensitive

Screen Shot 2024-01-30 at 10 46 17 AM

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Copy link

netlify bot commented Jan 30, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 60a33fe
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65b928294b20f00008b58775
😎 Deploy Preview https://deploy-preview-8775--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1e2da10) 47.42% compared to head (60a33fe) 42.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8775      +/-   ##
==========================================
- Coverage   47.42%   42.32%   -5.10%     
==========================================
  Files        1047      730     -317     
  Lines      166976   128365   -38611     
  Branches     2242     2242              
==========================================
- Hits        79185    54330   -24855     
+ Misses      87632    73876   -13756     
  Partials      159      159              
Flag Coverage Δ
harness ?
web 42.49% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/components/ProjectMoveModal.tsx 0.00% <0.00%> (ø)

... and 317 files with indirect coverage changes

Copy link
Contributor

@keita-determined keita-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mapmeld mapmeld merged commit 994527f into main Jan 30, 2024
80 of 91 checks passed
@mapmeld mapmeld deleted the pmove branch January 30, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants