test: add intg tests for tasks module #8750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8750 +/- ##
==========================================
- Coverage 47.58% 47.27% -0.31%
==========================================
Files 1049 1049
Lines 167354 167345 -9
Branches 2241 2241
==========================================
- Hits 79633 79118 -515
- Misses 87563 88069 +506
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
carolinaecalderon
force-pushed
the
bunify-task-tests
branch
5 times, most recently
from
32092d7
to
d1bb042
Compare
carolinaecalderon
requested review from
salonig23,
maxrussell and
NicholasBlaskey
4 tasks
salonig23
reviewed
Jan 31, 2024
NicholasBlaskey
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Looks good to me, nice work
I would wait for @salonig23 's approval too
carolinaecalderon
force-pushed
the
bunify-task-tests
branch
from
8b72e5d
to
da2f941
Compare
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add integration tests for all exported functions in
db/postgres_tasks.go, and initialize the db in TestMain.Add bun descriptions to the AllocationSession & TaskLog models, so that the ID key is auto-incremented with each addition.
Test Plan
See attached test.
Commentary (optional)
Truncated the start time in
RequireMockAllocationto match what the db stores.Remove
CheckTaskExistsfrompostgres_tasks.go, as it's used nowhere.Writing the tests first, then bun-ifying db/postgres_tasks.go in #8764
Checklist
docs/release-notes/.See Release Note for details.
Ticket
DET-10124