chore: make devcluster to rebuild bindings before harness and webui.
#8748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Comment on lines
+5
to
+6
| p: make -C bindings build && make -C harness clean build # rebuild Python | ||
| w: make -C bindings build && make -C webui build # rebuild Webui |
There was a problem hiding this comment.
make -C bindings build/python && make -C harness clean build
make -C bindings build/typescript && make -C webui build
There was a problem hiding this comment.
I don't feel strongly about this
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8748 +/- ##
===========================================
- Coverage 47.41% 38.85% -8.56%
===========================================
Files 1046 446 -600
Lines 166945 56000 -110945
Branches 2246 0 -2246
===========================================
- Hits 79150 21760 -57390
+ Misses 87636 34240 -53396
+ Partials 159 0 -159
Flags with carried forward coverage won't be shown. Click here to find out more. |
tools/devcluster.yaml
Outdated
| c: make -C docs build # rebuild doCs | ||
| p: make -C bindings build && make -C harness clean build # rebuild Python | ||
| w: make -C bindings build && make -C webui build # rebuild Webui | ||
| c: make -C docs build # rebuild docs |
There was a problem hiding this comment.
the capital letter was the mnemonic, same with Python and Webui
There was a problem hiding this comment.
it works better in Warcraft III where they use yellow letters in a white font. But with ascii, you have to work with what you got
rb-determined-ai
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Existing setup leaves users exposed to stale bindings build. Let's have the harness and webui build keybindings rebuild the proto bindings as well.
Test Plan
Commentary (optional)
https://hpe-aiatscale.slack.com/archives/C04TUNDGKMF/p1706040175088669
Checklist
docs/release-notes/.See Release Note for details.
Ticket