-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use the new genai docker repo #8745
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8745 +/- ##
==========================================
- Coverage 47.28% 47.28% -0.01%
==========================================
Files 1045 1045
Lines 166788 166788
Branches 2246 2246
==========================================
- Hits 78862 78861 -1
- Misses 87768 87769 +1
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tayritenour
changed the title
use the new genai docker repo
fix: use the new genai docker repo
Jan 24, 2024
tayritenour
force-pushed
the
genai-use-new-repo
branch
from
January 24, 2024 23:56
b9ee1e8
to
c10a79f
Compare
ioga
approved these changes
Jan 24, 2024
@@ -987,7 +987,7 @@ Resources: | |||
-p 9013:9013 \ | |||
-v /mnt/efs:/run/determined/workdir/shared_fs \ | |||
--network determined \ | |||
"determinedai/environments-dev:lore-backend-image-${GenAIVersion}" | |||
"determinedai/genai:${GenAIVersion}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
"determinedai/genai:${GenAIVersion}" | |
"${ImageRepoPrefix}/genai:${GenAIVersion}" |
tayritenour
force-pushed
the
genai-use-new-repo
branch
from
January 25, 2024 00:01
c10a79f
to
767038c
Compare
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This uses the new genai docker repo rather than the older repo we were using before.
Test Plan
Deploy a determined cluster on AWS. Example:
With your own cluster-id and keypair.
SSH into the master and confirm the docker image is from
determinedai/genai:latest
rather thandeterminedai/environments-dev:lore-backend-image-latest
Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket