Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the new genai docker repo #8745

Merged
merged 1 commit into from
Jan 25, 2024
Merged

fix: use the new genai docker repo #8745

merged 1 commit into from
Jan 25, 2024

Conversation

tayritenour
Copy link
Contributor

@tayritenour tayritenour commented Jan 24, 2024

Description

This uses the new genai docker repo rather than the older repo we were using before.

Test Plan

Deploy a determined cluster on AWS. Example:

det deploy aws up \
    --deployment-type genai \
    --genai-version latest \
    --det-v 0.27.0 \
    --aux-agent-instance-type m5.large \
    --compute-agent-instance-type g4dn.xlarge

With your own cluster-id and keypair.

SSH into the master and confirm the docker image is from determinedai/genai:latest rather than determinedai/environments-dev:lore-backend-image-latest

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 767038c
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65b1a4db81b0ea00088ff2d3

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d661404) 47.28% compared to head (767038c) 47.28%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8745      +/-   ##
==========================================
- Coverage   47.28%   47.28%   -0.01%     
==========================================
  Files        1045     1045              
  Lines      166788   166788              
  Branches     2246     2246              
==========================================
- Hits        78862    78861       -1     
- Misses      87768    87769       +1     
  Partials      158      158              
Flag Coverage Δ
backend 40.93% <ø> (-0.01%) ⬇️
harness 64.35% <0.00%> (ø)
web 42.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ness/determined/deploy/aws/deployment_types/vpc.py 54.28% <0.00%> (ø)

... and 3 files with indirect coverage changes

@tayritenour tayritenour changed the title use the new genai docker repo fix: use the new genai docker repo Jan 24, 2024
@tayritenour tayritenour requested a review from ioga January 24, 2024 23:52
@@ -987,7 +987,7 @@ Resources:
-p 9013:9013 \
-v /mnt/efs:/run/determined/workdir/shared_fs \
--network determined \
"determinedai/environments-dev:lore-backend-image-${GenAIVersion}"
"determinedai/genai:${GenAIVersion}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"determinedai/genai:${GenAIVersion}"
"${ImageRepoPrefix}/genai:${GenAIVersion}"

@tayritenour tayritenour enabled auto-merge (squash) January 25, 2024 00:16
@tayritenour tayritenour merged commit 87b6cf3 into main Jan 25, 2024
70 of 84 checks passed
@tayritenour tayritenour deleted the genai-use-new-repo branch January 25, 2024 00:23
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants