Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pagination fix in model detail page #8744

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Jan 24, 2024

Description

WEB-1326

Test Plan

  • Check if pagination works in model detail page

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Jan 24, 2024
@keita-determined keita-determined marked this pull request as ready for review January 24, 2024 20:54
Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 2cf8d94
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65b17916a3025b000861534f
😎 Deploy Preview https://deploy-preview-8744--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@keita-determined keita-determined requested a review from a team as a code owner January 24, 2024 20:54
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9f06d35) 47.44% compared to head (2cf8d94) 42.35%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8744      +/-   ##
==========================================
- Coverage   47.44%   42.35%   -5.10%     
==========================================
  Files        1045      728     -317     
  Lines      166790   128182   -38608     
  Branches     2246     2244       -2     
==========================================
- Hits        79135    54287   -24848     
+ Misses      87497    73737   -13760     
  Partials      158      158              
Flag Coverage Δ
harness ?
web 42.57% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/pages/ModelDetails.tsx 0.00% <0.00%> (ø)

... and 317 files with indirect coverage changes

@keita-determined keita-determined merged commit bd0a9ea into main Jan 24, 2024
77 of 88 checks passed
@keita-determined keita-determined deleted the fix/model-detail-pagination branch January 24, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants