perf: avoid loading model def in experiment model #8742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
NicholasBlaskey
commented
Jan 24, 2024
| }, user, | ||
| ) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("parsing continue experiment request: %w", err) | ||
| } | ||
| dbExp.ParentID = nil // Not actually a parent though. |
There was a problem hiding this comment.
the only parent logic was loading the model def which was unused
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8742 +/- ##
=======================================
Coverage 47.72% 47.72%
=======================================
Files 1049 1049
Lines 167238 167238
Branches 2241 2243 +2
=======================================
Hits 79816 79816
Misses 87264 87264
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
NicholasBlaskey
force-pushed
the
stop_loading_model_def
branch
from
0f57762
to
9429267
Compare
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We often load model def for experiments when we really shouldn't. This change makes it a lot harder to load the model def if you don't mean to.
Test Plan
Existing tests pass
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket