chore: add tests for agent_state.go queries #8740
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8740 +/- ##
==========================================
+ Coverage 47.26% 47.41% +0.15%
==========================================
Files 1045 1045
Lines 166700 166689 -11
Branches 2244 2242 -2
==========================================
+ Hits 78783 79034 +251
+ Misses 87759 87497 -262
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -667,8 +645,7 @@ func (a *agentState) restoreContainersField() error { | |||
| } | |||
|
|
|||
| func clearAgentStates(agentIds []agentID) error { | |||
| _, err := db.Bun().NewDelete().Where("agent_id in (?)", agentIds).Exec(context.TODO()) | |||
|
|
|||
| _, err := db.Bun().NewDelete().Model((*agentSnapshot)(nil)).Where("agent_id in (?)", agentIds).Exec(context.TODO()) | |||
There was a problem hiding this comment.
curious did this just not work before?
There was a problem hiding this comment.
nope, didn't work at all, i guess.
| log.Panicln(err) | ||
| } | ||
|
|
||
| err = db.MigrateTestPostgres(pgDB, "file://../../../static/migrations", "up") |
There was a problem hiding this comment.
this is a random note and I don't mean to change anything in this PR but I think the hashicorp video had some fact that tests like always assume you are running from some directory?
I guess my point is we shouldn't need to hard code this since we know what directory we are in
There was a problem hiding this comment.
we always run from the package directory, or the directory the tests are in. so we can hardcode it exactly like this?
There was a problem hiding this comment.
This isn't really related to this PR and should be a follow up ticket, I guess my point is MigrateTestPostgres shouldn't take a path at all
It should just like traverse its parent directories till it hits master then find the migrations
Would be cool if it was one line too so like
func TestMain(m testing.M) {
db.TestSetup(t)
}
Description
Exactly what it says.
Test Plan
Commentary (optional)
I removed the RP arg to retrieving agent states since restore is enabled by default for every resource pool now (plus, it was wrong, since I don't think it accounted for implicit default pools).
Checklist
docs/release-notes/.See Release Note for details.
Ticket
DET-10060