fix: local checkpoint download path fix #8722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8722 +/- ##
==========================================
- Coverage 47.26% 47.25% -0.01%
==========================================
Files 1045 1045
Lines 166692 166692
Branches 2244 2244
==========================================
- Hits 78780 78777 -3
- Misses 87754 87757 +3
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. |
NicholasBlaskey
approved these changes
Jan 22, 2024
| if !strings.HasSuffix(prefix, "/") { | ||
| prefix += "/" | ||
| } | ||
| return &LocalDownloader{ | ||
| aw: aw, | ||
| prefix: filepath.Clean(prefix), |
There was a problem hiding this comment.
why do we need filepath.Clean in the first place?
There was a problem hiding this comment.
the original instance of filepath.Clean in archivePath was added because the go sec linter desired some validation for open, altho one could argue we could ignore the linter there. it does seem helpful to cleanup the input here as we don't need to be as concerned with the internal implementation of filepath.Walk and what sort of path names might be returned when we trim the prefix during listing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue with local checkpoint download where file contents are relative to the root.
Test Plan
e2e tests
Commentary (optional)
This bug fix is for unreleased code in PR #8684.
Checklist
docs/release-notes/.See Release Note for details.
Ticket