feat: Add a modal to enable/disable Agents [WEB-1718] #8721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8721 +/- ##
==========================================
- Coverage 47.26% 42.09% -5.17%
==========================================
Files 1045 729 -316
Lines 166700 128322 -38378
Branches 2244 2245 +1
==========================================
- Hits 78783 54018 -24765
+ Misses 87759 74145 -13614
- Partials 158 159 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mapmeld
changed the title
mapmeld
force-pushed
the
resource_pool
branch
2 times, most recently
from
2731fd2
to
8740364
Compare
ashtonG
reviewed
Jan 22, 2024
|
|
||
| const onFormSubmit = useCallback(async () => { | ||
| for (const nodeId in toggleStates) { | ||
| if (toggleStates[nodeId] !== originalNodes[nodeId]) { |
There was a problem hiding this comment.
consider memoizing originalNodes so each render doesn't recalculate the node state. Alternatively (assuming the endpoints are idempotent), keep track of which endpoints were touched and apply the endpoints that way.
mapmeld
force-pushed
the
resource_pool
branch
from
8740364
to
9ca6fce
Compare
ashtonG
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When admin views a cluster resource pool, they'll see a dropdown in the breadcrumbs section:
If there are no active agents, there is a Message
If there are available agents, they appear as a set of toggle switches reflecting enabled/disabled state.
The "Apply Changes" button becomes enabled once changes are made.
When there are 10+ toggles, there is a text filter:
The original ticket suggests a dropdown to allow jobs to finish or 'gracefully terminate', but no such option is available in the current EnableAgent Go code
Test Plan
I've included
const defaultNodesandnodes = defaultNodesas comments; uncommenting these makes two agents visible. When you click Apply Changes, you will see an API call and error (because these are not real agent IDs).Checklist
docs/release-notes/.See Release Note for details.