Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: [FE-269] Add documentation detailing configuration steps to set the values for ngpus. #8714

Merged
merged 3 commits into from
Jan 19, 2024
Merged

docs: [FE-269] Add documentation detailing configuration steps to set the values for ngpus. #8714

merged 3 commits into from
Jan 19, 2024

Conversation

jagadeesh545
Copy link
Contributor

@jagadeesh545 jagadeesh545 commented Jan 18, 2024 •
edited
Loading

Description

FE-269
DeterminedAI cannot function properly on an HPC cluster with PBS if the ngpus resource is not configured properly. Add instructions to the PBS Requirements section explaining how to configure the ngpus resource.

Test Plan

Tested manually.
Screenshot 2024-01-18 at 22 34 34
Screenshot 2024-01-18 at 22 34 43
Screenshot 2024-01-18 at 22 34 53

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

FE-269

@cla-bot cla-bot bot added the cla-signed label Jan 18, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 18, 2024 •
edited
Loading

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 1351cbc
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65a9f9bb7e7e2a0008500376

@determined-ci determined-ci added the documentation Improvements or additions to documentation label Jan 18, 2024
@determined-ci determined-ci requested a review from a team January 18, 2024 17:49
@jagadeesh545 jagadeesh545 requested a review from a team January 18, 2024 17:49
tara-det-ai
tara-det-ai reviewed Jan 18, 2024
View reviewed changes
Copy link
Member

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested edits, check for duplicates

@determined-ci determined-ci requested a review from a team January 19, 2024 04:14
@jagadeesh545
Copy link
Contributor Author

Updated text as suggested and removed the duplicate section.

tara-det-ai
tara-det-ai approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jagadeesh545 jagadeesh545 merged commit 92fe3a6 into main Jan 19, 2024
72 of 83 checks passed
@jagadeesh545 jagadeesh545 deleted the fe-269 branch January 19, 2024 16:08
@rcorujo rcorujo mentioned this pull request Jan 20, 2024
Merged
4 tasks
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
@jagadeesh545 @maxrussell
docs: [FE-269] Add documentation detailing configuration steps to set…
20f30c0 
… the values for ngpus. (#8714)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tara-det-ai tara-det-ai tara-det-ai approved these changes

Assignees
No one assigned
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jagadeesh545 @tara-det-ai @determined-ci