-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use hew Alert [WEB-1918] #8711
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8711 +/- ##
==========================================
- Coverage 47.25% 42.13% -5.13%
==========================================
Files 1045 728 -317
Lines 166692 128170 -38522
Branches 2244 2244
==========================================
- Hits 78773 54006 -24767
+ Misses 87761 74006 -13755
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Confirmed that Alert replaces Message in these locations
Description
We previously consolidated "Alerts" and "Messages", but we decided to revert that, since some cases may call for a smaller banner "Alert" vs. a larger format "Message"
Test Plan
Alert
(horizontal, color, smaller):and NOT a
Message
(vertical, no color, larger):Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket
WEB-1918