Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use hew Alert [WEB-1918] #8711

Merged
merged 8 commits into from
Jan 22, 2024
Merged

fix: use hew Alert [WEB-1918] #8711

merged 8 commits into from
Jan 22, 2024

Conversation

johnkim-det
Copy link
Contributor

Description

We previously consolidated "Alerts" and "Messages", but we decided to revert that, since some cases may call for a smaller banner "Alert" vs. a larger format "Message"

Test Plan

  • Archive a model
  • View model details page, make sure the archived status message is an Alert (horizontal, color, smaller):

Screen Shot 2024-01-18 at 11 11 06 AM

and NOT a Message (vertical, no color, larger):
Screen Shot 2024-01-18 at 11 12 18 AM

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

WEB-1918

@johnkim-det johnkim-det requested a review from a team as a code owner January 18, 2024 16:16
@cla-bot cla-bot bot added the cla-signed label Jan 18, 2024
Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 69fc714
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65aeb819354bdb0008cf5725
😎 Deploy Preview https://deploy-preview-8711--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (f32e015) 47.25% compared to head (69fc714) 42.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8711      +/-   ##
==========================================
- Coverage   47.25%   42.13%   -5.13%     
==========================================
  Files        1045      728     -317     
  Lines      166692   128170   -38522     
  Branches     2244     2244              
==========================================
- Hits        78773    54006   -24767     
+ Misses      87761    74006   -13755     
  Partials      158      158              
Flag Coverage Δ
harness ?
web 42.57% <46.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...bui/react/src/components/ExperimentCreateModal.tsx 77.35% <100.00%> (ø)
webui/react/src/components/ExperimentStopModal.tsx 89.18% <100.00%> (ø)
...react/src/components/HyperparameterSearchModal.tsx 89.92% <100.00%> (ø)
webui/react/src/components/JupyterLabModal.tsx 84.33% <100.00%> (ø)
webui/react/src/components/UserSettingsModal.tsx 19.62% <100.00%> (ø)
...ct/src/pages/TrialDetails/TrialDetailsProfiles.tsx 46.66% <50.00%> (+1.21%) ⬆️
...mentDetails/ExperimentVisualization/HpHeatMaps.tsx 16.42% <33.33%> (+0.20%) ⬆️
.../ExperimentVisualization/HpParallelCoordinates.tsx 12.66% <33.33%> (+0.19%) ⬆️
...Details/ExperimentVisualization/HpScatterPlots.tsx 14.80% <33.33%> (+0.28%) ⬆️
...tDetails/ExperimentVisualization/LearningCurve.tsx 29.28% <33.33%> (+0.18%) ⬆️
... and 4 more

... and 317 files with indirect coverage changes

Copy link
Contributor

@mapmeld mapmeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Confirmed that Alert replaces Message in these locations

@johnkim-det johnkim-det merged commit 0bda0d9 into main Jan 22, 2024
74 of 85 checks passed
@johnkim-det johnkim-det deleted the WEB-1918 branch January 22, 2024 19:57
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants