fix: restore original user store poll on leaving workspace details #8702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes an issue where the user store would cease polling when leaving the workspace details page. we start polling the user store at 10s (up from 60s) when getting to the workspace details page. by default, the `startPolling` function returns a cleanup function that stops polling altogether on unmount, so the user store would stop polling when the user leaves the workspace details page. this fixes that by instead polling at the original amount on unmount
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8702 +/- ##
==========================================
- Coverage 51.51% 47.32% -4.19%
==========================================
Files 887 570 -317
Lines 156209 117676 -38533
Branches 2088 2088
==========================================
- Hits 80465 55691 -24774
+ Misses 74251 60492 -13759
Partials 1493 1493
Flags with carried forward coverage won't be shown. Click here to find out more. |
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
…8702) this fixes an issue where the user store would cease polling when leaving the workspace details page. we start polling the user store at 10s (up from 60s) when getting to the workspace details page. by default, the `startPolling` function returns a cleanup function that stops polling altogether on unmount, so the user store would stop polling when the user leaves the workspace details page. this fixes that by instead polling at the original amount on unmount
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this fixes an issue where the user store would cease polling when leaving the workspace details page. we start polling the user store at 10s (up from 60s) when getting to the workspace details page. by default, the
startPollingfunction returns a cleanup function that stops polling altogether on unmount, so the user store would stop polling when the user leaves the workspace details page. this fixes that by instead polling at the original amount on unmount.Test Plan
Commentary (optional)
opted against an "increase/descrease polling" function because this is the only place in the codebase where we do this. we can revisit if this becomes more of a thing later.
Checklist
docs/release-notes/.See Release Note for details.
Ticket
WEB-1807