Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix CreateExperiment for Remote Users #8700

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Conversation

salonig23
Copy link
Contributor

Description

taskSpec.ExtraEnvVars was not initialized in the case of remote users which was causing a panic whenever the user tried to create an experiment

Test Plan

Log in as a remote user and check if you can create an experiment

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@salonig23 salonig23 requested a review from a team as a code owner January 17, 2024 00:41
@cla-bot cla-bot bot added the cla-signed label Jan 17, 2024
Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit fcb69e2
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65a811547332150008b4c358

@salonig23 salonig23 requested review from maxrussell and removed request for carolinaecalderon January 17, 2024 00:42
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6ccc7dc) 48.95% compared to head (fcb69e2) 45.58%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8700      +/-   ##
==========================================
- Coverage   48.95%   45.58%   -3.38%     
==========================================
  Files         634      701      +67     
  Lines       81788   142197   +60409     
  Branches        0     2088    +2088     
==========================================
+ Hits        40042    64817   +24775     
- Misses      40261    75887   +35626     
- Partials     1485     1493       +8     
Flag Coverage Δ
harness 37.21% <ø> (-26.05%) ⬇️
web 53.77% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/api_experiment.go 45.42% <100.00%> (+0.06%) ⬆️
master/internal/experiment.go 21.19% <0.00%> (+0.03%) ⬆️

... and 527 files with indirect coverage changes

@salonig23 salonig23 changed the title fix: fic CreateExperiment for Remote Users fix: fix CreateExperiment for Remote Users Jan 17, 2024
@NicholasBlaskey NicholasBlaskey added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Jan 17, 2024
@NicholasBlaskey NicholasBlaskey merged commit f2899cc into main Jan 17, 2024
74 of 87 checks passed
@NicholasBlaskey NicholasBlaskey deleted the fix-create-exp branch January 17, 2024 18:53
dai-release bot pushed a commit that referenced this pull request Jan 17, 2024
varlogtim added a commit that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants