Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update github path in docker docs #8687

Merged
merged 1 commit into from
Jan 19, 2024
Merged

chore: update github path in docker docs #8687

merged 1 commit into from
Jan 19, 2024

Conversation

dannysauer
Copy link
Member

master moved to main; update URL to match

Description

Update a github path we missed in the branch rename

Test Plan

Click the link. Does it work? Yes.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@dannysauer
chore: update github path in docker docs
bbef3be 
master moved to main; update URL to match
@cla-bot cla-bot bot added the cla-signed label Jan 12, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 12, 2024 •
edited
Loading

✅ Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit bbef3be
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65a16677dda6c80008e5cf09
😎 Deploy Preview https://deploy-preview-8687--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

This PR was opened from a forked repository. You should use a branch on the central repository instead.

@determined-ci determined-ci requested a review from a team January 12, 2024 16:19
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Jan 12, 2024
@dannysauer
Copy link
Member Author

Ugh. I pushed to the wrong upstream.

Well, the GPU tests aren't relevant anyway. 🤦

tara-det-ai
tara-det-ai approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannysauer
Copy link
Member Author

Not wasting CI resources retesting this. :)

@dannysauer dannysauer merged commit b69a49c into determined-ai:main Jan 19, 2024
64 of 70 checks passed
@dannysauer dannysauer deleted the chore/dannys/update-github-path branch January 19, 2024 01:28
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
@dannysauer @maxrussell
chore: update github path in docker docs (#8687)
0ddf3dc 
master moved to main; update URL to match
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tara-det-ai tara-det-ai tara-det-ai approved these changes

Assignees
No one assigned
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dannysauer @tara-det-ai @determined-ci