chore: Port smaller Antd.Modals to standard Hew Modal #8567
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
webui/react/src/pages/WorkspaceDetails/WorkspaceQuickSearchModalComponent.tsx
Show resolved
Hide resolved
| handleError: () => {}, | ||
| handler: () => {}, | ||
| onComplete: onCancel, | ||
| text: 'Ok', |
There was a problem hiding this comment.
I think this one should be Close
There was a problem hiding this comment.
@mapmeld let me know if you had something else in mind, but I see an issue where we don't have "an informational / Close modal" variation and the "submit" is required. I can add the "cancel" here and have both submit and cancel do the same thing, or keep as is, I am fine with either. But I think the real solution is to add an "informational / Close modal" to Hew.
There was a problem hiding this comment.
I got the idea from the GalleryModal. Is this modal different because it can make changes (handleTrialUnselect) ?
There was a problem hiding this comment.
@mapmeld I think I misunderstood what you were saying at first let me know if it looks better now.
| submit={{ | ||
| handleError: () => {}, | ||
| handler: onOk, | ||
| text: 'Ok', |
There was a problem hiding this comment.
this would also be an informational / Close modal
webui/react/src/pages/ExperimentDetails/ExperimentVisualization/HpParallelCoordinates.tsx
Outdated
Show resolved
Hide resolved
Description
This PR updates our smaller and simpler modals to use the Hew Modal.
One Modal needed an update in Hew in order to expect the
MouseEventon the "Ok" button click the relevant PR is here determined-ai/hew#75.Once the above PR is merged in I will properly update the
Hewversion in our packages.Test Plan
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket