Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding PACHD_ADDRESS and DEX_TOKEN to task env [DET-9875] #8473

Merged
merged 1 commit into from
Nov 28, 2023
Merged

feat: adding PACHD_ADDRESS and DEX_TOKEN to task env [DET-9875] #8473

merged 1 commit into from
Nov 28, 2023

Conversation

salonig23
Copy link
Contributor

@salonig23 salonig23 commented Nov 23, 2023 •
edited
Loading

Description

Added PACHD_ADDRESS to the task environment variables as a part of pachyderm user provisioning.

Test Plan

  1. Create a Kubernetes cluster using the determined repo.
  2. Checkout branch saloni-gupta-pachyderm-intg.
  3. Add your pachyderm address to the ./devcluster.yaml:
integrations:
  pachyderm:
    address: "foo"
  1. Start the devcluster
  2. Open a jupyter notebook.
  3. Run the command !env in the notebook.
  4. Verify that the PACHD_ADDRESS environment variable is the same as the one you put in the ./devcluster.yaml file.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Nov 23, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 23, 2023 •
edited
Loading

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit a4faf10
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6564e8422ab2c50008b642b6

@salonig23 salonig23 marked this pull request as ready for review November 23, 2023 09:24
@salonig23 salonig23 requested a review from a team as a code owner November 23, 2023 09:24
stoksc
stoksc reviewed Nov 27, 2023
View reviewed changes
Copy link
Contributor

@stoksc stoksc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm minus one bug i commented

master/internal/api_command.go Outdated Show resolved Hide resolved
master/internal/api_command.go Outdated Show resolved Hide resolved
stoksc
stoksc approved these changes Nov 27, 2023
View reviewed changes
master/internal/api_shell.go Outdated Show resolved Hide resolved
master/internal/api_command.go Outdated Show resolved Hide resolved
@stoksc
Copy link
Contributor

stoksc commented Nov 27, 2023

lgtm modulo some style comments

@salonig23 salonig23 changed the title feat: adding PACHD_ADDRESS and DEX_TOKEN to task env feat: adding PACHD_ADDRESS and DEX_TOKEN to task env [DET-9875] Nov 28, 2023
@salonig23 salonig23 merged commit a2730cb into main Nov 28, 2023
88 of 95 checks passed
@salonig23 salonig23 deleted the add_pachd_dextoken_changes branch November 28, 2023 00:59
NicholasBlaskey added a commit that referenced this pull request Nov 28, 2023
@NicholasBlaskey
Revert "feat: adding PACHD_ADDRESS and DEX_TOKEN to task env (#8473)"
6c70698 
This reverts commit a2730cb.
@dannysauer dannysauer added this to the 0.26.5 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stoksc stoksc stoksc approved these changes

@carolinaecalderon carolinaecalderon Awaiting requested review from carolinaecalderon

Assignees

@stoksc stoksc

Labels
cla-signed
Projects
None yet
Milestone
0.26.5
Development

Successfully merging this pull request may close these issues.
3 participants
@salonig23 @stoksc @dannysauer