test: fix slow delete_checkpoint test #8377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
stoksc
approved these changes
Nov 8, 2023
4 tasks
rb-determined-ai
approved these changes
Nov 9, 2023
This reverts commit 73d4636.
NicholasBlaskey
force-pushed
the
fix_slow_checkpoint_test
branch
from
c597ef3
to
2d58972
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checkpoint GC was taking 15 minutes each time due to a few bugs.
First bug we waited 5x2 minutes for both experiments to finish checkpoint gc after they ran. They didn't run a checkpoint gc since they reported 10 checkpoints and had a 10 checkpoint save amount.
Second bug is we were giving the wrong checkpoint uuids causing only one checkpoint gc to run.
Third bug is running wait_for_checkpoint gc after each other. They should be combined.
Test Plan
CI passes/
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket