fix: Kill task permission on interactive page #8358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ashtonG
reviewed
Nov 16, 2023
Comment on lines
37
to
58
| const [task, setTask] = useState<CommandTask>(); | ||
|
|
||
| const getTaskById = useCallback(async (taskType: CommandType, commandId: string) => { | ||
| switch (taskType) { | ||
| case 'command': | ||
| setTask(await getCommand({ commandId })); | ||
| break; | ||
| case 'jupyter-lab': | ||
| setTask(await getJupyterLab({ commandId })); | ||
| break; | ||
| case 'shell': | ||
| setTask(await getShell({ commandId })); | ||
| break; | ||
| case 'tensor-board': | ||
| setTask(await getTensorBoard({ commandId })); | ||
| break; | ||
| } | ||
| }, []); | ||
|
|
||
| useEffect(() => { | ||
| getTaskById(type, id); | ||
| }, [type, id, getTaskById]); |
There was a problem hiding this comment.
consider using useAsync here -- it wraps the value in a Loadable (which we should do here because now it's possible for the task to not load) and handles race conditions:
Suggested change
| const [task, setTask] = useState<CommandTask>(); | |
| const getTaskById = useCallback(async (taskType: CommandType, commandId: string) => { | |
| switch (taskType) { | |
| case 'command': | |
| setTask(await getCommand({ commandId })); | |
| break; | |
| case 'jupyter-lab': | |
| setTask(await getJupyterLab({ commandId })); | |
| break; | |
| case 'shell': | |
| setTask(await getShell({ commandId })); | |
| break; | |
| case 'tensor-board': | |
| setTask(await getTensorBoard({ commandId })); | |
| break; | |
| } | |
| }, []); | |
| useEffect(() => { | |
| getTaskById(type, id); | |
| }, [type, id, getTaskById]); | |
| const task = useAsync(() => { | |
| const call = { | |
| command: getCommand, | |
| 'jupyter-lab': getJupyterLab | |
| shell: getShell, | |
| 'tensor-board': getTensorBoard | |
| }[type] | |
| return call({ commandId: id }); | |
| }, [type, id]) |
ashtonG
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Interactive task used to not have access to the workspace id, so the permission check for killing task is always false for non-admin.
Test Plan
Log in as a user with workspace admin role
Create a notebook in that workspace
Notebook can be killed from
/det/taskspage, as well as on/det/interactivepageCommentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket
WEB-1268