Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin ruamel.yaml<0.18.0 #8232

Merged
merged 1 commit into from
Oct 24, 2023
Merged

fix: pin ruamel.yaml<0.18.0 #8232

merged 1 commit into from
Oct 24, 2023

Conversation

rb-determined-ai
Copy link
Member

There was a breaking change in the ruamel.yaml API, which has the unfortunate effect on our cli of causing commands like det e config to emit absolutely no error message, just exit 1 silently.

The fix is too big to squeeze into the release so we will use a pin until the real fix is ready.

There was a breaking change in the ruamel.yaml API, which has the
unfortunate effect on our cli of causing commands like `det e config` to
emit absolutely no error message, just exit 1 silently.

The fix is too big to squeeze into the release so we will use a pin
until the real fix is ready.
@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 8ea8b80
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6537f4f9cfb13000071846cd

@rb-determined-ai rb-determined-ai added to-cherry-pick Pull requests that need to be cherry-picked into the current release and removed cla-signed labels Oct 24, 2023
@rb-determined-ai rb-determined-ai merged commit 12e23b0 into main Oct 24, 2023
71 of 84 checks passed
@rb-determined-ai rb-determined-ai deleted the rb/pin-ruamel branch October 24, 2023 17:42
dai-release bot pushed a commit that referenced this pull request Oct 24, 2023
There was a breaking change in the ruamel.yaml API, which has the
unfortunate effect on our cli of causing commands like `det e config` to
emit absolutely no error message, just exit 1 silently.

The fix is too big to squeeze into the release so we will use a pin
until the real fix is ready.

(cherry picked from commit 12e23b0)
@dannysauer dannysauer added this to the 0.26.3 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants