fix: nil deref in ReadPreemptionStatus (#8979)

master/internal/config/config.go

@@ -481,7 +481,7 @@ func ReadRMPreemptionStatus(rpName string) bool {
 	for _, r := range config.ResourceManagers() {
 		for _, rpConfig := range r.ResourcePools {
 			if rpConfig.PoolName == rpName {
-				if rpConfig.Scheduler == nil {
+				if rpConfig.Scheduler != nil {
 					return rpConfig.Scheduler.GetPreemption()
 				}
 				// if not found, fall back to resource manager config

master/internal/config/config_test.go

@@ -839,6 +839,13 @@ func TestMultiRMPreemptionAndPriority(t *testing.T) {
 					DefaultPriority: &prio1,
 				}},
 			}}},
+			// nil preemption case
+			{
+				ResourceManager: &ResourceManagerConfig{KubernetesRM: &KubernetesResourceManagerConfig{
+					Name: "nil-rm", DefaultScheduler: "not-preemption-scheduler",
+				}},
+				ResourcePools: []ResourcePoolConfig{{PoolName: "nil-rp"}},
+			},
 		},
 	}
 
@@ -867,4 +874,12 @@ func TestMultiRMPreemptionAndPriority(t *testing.T) {
 
 	priority = ReadPriority("default234", model.CommandConfig{})
 	require.Equal(t, prio1, priority)
+
+	// 'nil-rp' RP exists under 'nil-rm' RM, so the preemption
+	// & priority default to the RMs.
+	status = ReadRMPreemptionStatus("nil-rp")
+	require.False(t, status)
+
+	priority = ReadPriority("nil-rp", model.CommandConfig{})
+	require.Equal(t, KubernetesDefaultPriority, priority)
 }

master/internal/experiment_job_service.go

@@ -36,12 +36,11 @@ func (e *internalExperiment) ToV1Job() (*jobv1.Job, error) {
 		WorkspaceId:    int32(workspace.ID),
 	}
 
+	j.ResourcePool = e.activeConfig.Resources().ResourcePool()
 	j.IsPreemptible = config.ReadRMPreemptionStatus(j.ResourcePool)
 	j.Priority = int32(config.ReadPriority(j.ResourcePool, &e.activeConfig))
 	j.Weight = config.ReadWeight(j.ResourcePool, &e.activeConfig)
 
-	j.ResourcePool = e.activeConfig.Resources().ResourcePool()
-
 	return &j, nil
 }