Skip to content

Commit

Permalink
ci: more e2e test fixes (#8881)
Browse files Browse the repository at this point in the history
create_test_user was returning a nonsense username in some cases.
  • Loading branch information
rb-determined-ai authored Feb 23, 2024
1 parent ab9505c commit 944732a
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions e2e_tests/tests/api_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,10 @@ def create_test_user(
Returns a tuple of (Session, password).
"""
session = admin_session()
username = get_random_string()
user = user or bindings.v1User(username=username, admin=False, active=True)
user = user or bindings.v1User(username=get_random_string(), admin=False, active=True)
password = get_random_string()
bindings.post_PostUser(session, body=bindings.v1PostUserRequest(user=user, password=password))
sess = make_session(username, password)
sess = make_session(user.username, password)
return sess, password


Expand Down

0 comments on commit 944732a

Please sign in to comment.