refactor: columnpicker remove hard coded value (#9342)

determined-ai · May 10, 2024 · 7c26fe1 · 7c26fe1
1 parent feb8a7b
commit 7c26fe1
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/webui/react/src/components/ColumnPickerMenu.tsx b/webui/react/src/components/ColumnPickerMenu.tsx
@@ -263,11 +263,7 @@ const ColumnPickerMenu: React.FC<ColumnMenuProps> = ({
         <div className={css.base}>
           {tabs.length > 1 && (
             <Pivot
-              items={[
-                V1LocationType.EXPERIMENT,
-                [V1LocationType.VALIDATIONS, V1LocationType.TRAINING, V1LocationType.CUSTOMMETRIC],
-                V1LocationType.HYPERPARAMETERS,
-              ].map((tab) => {
+              items={tabs.map((tab) => {
                 const canonicalTab = Array.isArray(tab) ? tab[0] : tab;
                 return {
                   children: (
@@ -284,7 +280,7 @@ const ColumnPickerMenu: React.FC<ColumnMenuProps> = ({
                   ),
                   forceRender: true,
                   key: canonicalTab,
-                  label: locationLabelMap[canonicalTab],
+                  label: locationLabelMap[canonicalTab as keyof typeof locationLabelMap],
                 };
               })}
             />
@@ -305,7 +301,10 @@ const ColumnPickerMenu: React.FC<ColumnMenuProps> = ({
       }
       open={open}
       onOpenChange={handleOpenChange}>
-      <Button hideChildren={isMobile} icon={<Icon name="columns" title="column picker" />}>
+      <Button
+        data-test-component="columnPickerMenu"
+        hideChildren={isMobile}
+        icon={<Icon name="columns" title="column picker" />}>
         Columns
       </Button>
     </Dropdown>