Skip to content

Commit

Permalink
test: fix test_logging typehint syntax error (#9142)
Browse files Browse the repository at this point in the history
(cherry picked from commit 3f7a396)
  • Loading branch information
hamidzr authored and determined-ci committed Apr 10, 2024
1 parent 61999f4 commit 691d190
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions e2e_tests/tests/cluster/test_logging.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
LogFields = Union[bindings.v1TaskLogsFieldsResponse, bindings.v1TrialLogsFieldsResponse]


def _test_trial_logs(log_regex: re.Pattern[str]) -> None:
def _test_trial_logs(log_regex: re.Pattern) -> None:
sess = api_utils.user_session()

experiment_id = exp.run_basic_test(
Expand Down Expand Up @@ -69,9 +69,7 @@ def test_trial_logs() -> None:
_test_trial_logs(log_regex)


def _test_task_logs(
task_type: str, task_config: Dict[str, Any], log_regex: re.Pattern[str]
) -> None:
def _test_task_logs(task_type: str, task_config: Dict[str, Any], log_regex: re.Pattern) -> None:
sess = api_utils.user_session()

rps = bindings.get_GetResourcePools(sess)
Expand Down Expand Up @@ -177,7 +175,7 @@ def test_task_logs(task_type: str, task_config: Dict[str, Any], log_regex: Any)


def check_logs(
log_regex: Any,
log_regex: re.Pattern,
log_fn: Callable[..., Iterable[Log]],
log_fields_fn: Callable[..., Iterable[LogFields]],
) -> None:
Expand Down

0 comments on commit 691d190

Please sign in to comment.