Skip to content

Commit

Permalink
chore: deprecate PPC64/POWER builds (#9467)
Browse files Browse the repository at this point in the history
  • Loading branch information
ShreyaLnuHpe authored Jun 4, 2024
1 parent 13a5142 commit 4d8596c
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 84 deletions.
17 changes: 0 additions & 17 deletions agent/.goreleaser.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ builds:
goarch:
- amd64
- arm64
- ppc64

archives:
- wrap_in_directory: "true"
Expand Down Expand Up @@ -123,37 +122,21 @@ dockers:
extra_files:
- packaging/entrypoint.sh
- packaging/LICENSE
# ppc64
- goos: linux
goarch: ppc64
use: buildx
build_flag_templates:
- --platform=linux/ppc64le
- --builder=buildx-build
image_templates:
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-ppc64"
extra_files:
- packaging/entrypoint.sh
- packaging/LICENSE

docker_manifests:
- name_template: "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}"
image_templates:
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-amd64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-arm64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-ppc64"
- name_template: "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.ShortCommit}}"
image_templates:
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-amd64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-arm64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-ppc64"
- name_template: "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.Env.VERSION}}"
image_templates:
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-amd64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-arm64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-ppc64"
- name_template: "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:latest"
image_templates:
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-amd64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-arm64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-ppc64"
17 changes: 0 additions & 17 deletions agent/.goreleaser_ee.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ builds:
goarch:
- amd64
- arm64
- ppc64

archives:
- wrap_in_directory: "true"
Expand Down Expand Up @@ -125,37 +124,21 @@ dockers:
extra_files:
- packaging/entrypoint.sh
- packaging/LICENSE
# ppc64
- goos: linux
goarch: ppc64
use: buildx
build_flag_templates:
- --platform=linux/ppc64le
- --builder=buildx-build
image_templates:
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-ppc64"
extra_files:
- packaging/entrypoint.sh
- packaging/LICENSE

docker_manifests:
- name_template: "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}"
image_templates:
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-amd64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-arm64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-ppc64"
- name_template: "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.ShortCommit}}"
image_templates:
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-amd64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-arm64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-ppc64"
- name_template: "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.Env.VERSION}}"
image_templates:
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-amd64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-arm64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-ppc64"
- name_template: "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:latest"
image_templates:
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-amd64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-arm64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-ppc64"
3 changes: 1 addition & 2 deletions agent/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ FULL_COMMIT = $(shell git rev-parse HEAD)
SHORT_COMMIT = $(shell git rev-parse HEAD | head -c9)
PROJECT_NAME = determined-agent
EE_PROJECT_NAME = hpe-mlde-agent
ARCHS = amd64 arm64 ppc64
ARCHS = amd64 arm64
MULTI_ARCH_IMAGES = $(shell for arch in $(ARCHS); do echo $(DOCKER_REPO)/$(PROJECT_NAME):$(FULL_COMMIT)-$$arch; done)
EE_MULTI_ARCH_IMAGES = $(shell for arch in $(ARCHS); do echo $(DOCKER_REPO)/$(EE_PROJECT_NAME):$(FULL_COMMIT)-$$arch; done)

Expand Down Expand Up @@ -91,7 +91,6 @@ buildx:
{ \
platforms=(); \
for arch in $(ARCHS); do \
[ $$arch == "ppc64" ] && arch="ppc64le"; \
platforms+=("linux/$$arch"); \
done; \
platform_list=$$(IFS=, ; echo "$${platforms[*]}"); \
Expand Down
6 changes: 6 additions & 0 deletions docs/release-notes/deprecate-ppc64.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
:orphan:

**Deprecations**

- Machine Architectures: Due to underutilized AgentRM features, support for PPC64/POWER builds is
deprecated. Users should transition to ARM64/AMD64.
23 changes: 0 additions & 23 deletions master/.goreleaser.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ builds:
goarch:
- amd64
- arm64
- ppc64
- main: ./cmd/determined-gotmpl
id: determined-gotmpl
binary: determined-gotmpl
Expand All @@ -29,7 +28,6 @@ builds:
goarch:
- amd64
- arm64
- ppc64

archives:
- wrap_in_directory: "true"
Expand Down Expand Up @@ -181,42 +179,21 @@ dockers:
ids:
- determined-master
- determined-gotmpl
# ppc64
- goos: linux
goarch: ppc64
use: buildx
build_flag_templates:
- --platform=linux/ppc64le
- --builder=buildx-build
image_templates:
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-ppc64"
extra_files:
- "packaging/master.yaml"
- "packaging/LICENSE"
- "build"
- "static"
ids:
- determined-master
- determined-gotmpl

docker_manifests:
- name_template: "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}"
image_templates:
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-amd64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-arm64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-ppc64"
- name_template: "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.ShortCommit}}"
image_templates:
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-amd64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-arm64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-ppc64"
- name_template: "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.Env.VERSION}}"
image_templates:
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-amd64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-arm64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-ppc64"
- name_template: "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:latest"
image_templates:
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-amd64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-arm64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-ppc64"
23 changes: 0 additions & 23 deletions master/.goreleaser_ee.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ builds:
goarch:
- amd64
- arm64
- ppc64
- main: ./cmd/determined-gotmpl
id: determined-gotmpl
binary: determined-gotmpl
Expand All @@ -33,7 +32,6 @@ builds:
goarch:
- amd64
- arm64
- ppc64

archives:
- wrap_in_directory: "true"
Expand Down Expand Up @@ -187,42 +185,21 @@ dockers:
ids:
- determined-ee-master
- determined-gotmpl
# ppc64
- goos: linux
goarch: ppc64
use: buildx
build_flag_templates:
- --platform=linux/ppc64le
- --builder=buildx-build
image_templates:
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-ppc64"
extra_files:
- "packaging/master.yaml"
- "packaging/LICENSE"
- "build"
- "static"
ids:
- determined-ee-master
- determined-gotmpl

docker_manifests:
- name_template: "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}"
image_templates:
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-amd64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-arm64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-ppc64"
- name_template: "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.ShortCommit}}"
image_templates:
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-amd64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-arm64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-ppc64"
- name_template: "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.Env.VERSION}}"
image_templates:
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-amd64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-arm64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-ppc64"
- name_template: "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:latest"
image_templates:
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-amd64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-arm64"
- "{{.Env.DOCKER_REPO}}/{{.ProjectName}}:{{.FullCommit}}-ppc64"
3 changes: 1 addition & 2 deletions master/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ FULL_COMMIT = $(shell git rev-parse HEAD)
SHORT_COMMIT = $(shell git rev-parse HEAD | head -c9)
PROJECT_NAME = determined-master
EE_PROJECT_NAME = hpe-mlde-master
ARCHS = amd64 arm64 ppc64
ARCHS = amd64 arm64
ARCH_SMALL = amd64-shared-cluster
MULTI_ARCH_IMAGES = $(shell for arch in $(ARCHS); do echo $(DOCKER_REPO)/$(PROJECT_NAME):$(FULL_COMMIT)-$$arch; done)
EE_MULTI_ARCH_IMAGES = $(shell for arch in $(ARCHS); do echo $(DOCKER_REPO)/$(EE_PROJECT_NAME):$(FULL_COMMIT)-$$arch; done)
Expand Down Expand Up @@ -221,7 +221,6 @@ buildx:
{ \
platforms=(); \
for arch in $(ARCHS); do \
[ $$arch == "ppc64" ] && arch="ppc64le"; \
platforms+=("linux/$$arch"); \
done; \
platform_list=$$(IFS=, ; echo "$${platforms[*]}"); \
Expand Down

0 comments on commit 4d8596c

Please sign in to comment.