Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortened links in the user mini-menu resolve to the shortened broken text as seen. #479

Open
xmif opened this issue May 30, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@xmif
Copy link

xmif commented May 30, 2024

Example:
image

Top link hover/click:
image

Bottom link hover/click:
image

Link used in the example screenshots: clicky! - links that get shortened seem to behave the same, could be reproduced on both Firefox and Chromium (Edge).

@reda777
Copy link
Contributor

reda777 commented Jun 1, 2024

This line in the file "assets/chat/js/menus/ChatUserInfoMenu.js"

const msg = MessageBuilder.message(text, new ChatUser(nick)); I think MessageBuilder.message() is supposed to take the text that the user types, but the generated message for the floating menu uses the text from the chat containing the shortened link.

Either remove this part of the code and just copy the div node from the chat, or change the href value to the correct one.

@11k 11k added the bug Something isn't working label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants