Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-allowed-attr ignore aria-multiline=false on element with contenteditable #4463

Closed
WilcoFiers opened this issue May 15, 2024 · 1 comment · Fixed by #4537
Closed

aria-allowed-attr ignore aria-multiline=false on element with contenteditable #4463

WilcoFiers opened this issue May 15, 2024 · 1 comment · Fixed by #4537
Assignees
Labels
fix Bug fixes rules Issue or false result from an axe-core rule support
Milestone

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented May 15, 2024

We've seen examples where devs have put aria-multinline=false on elements with contenteditable, with a role that doesn't support them. The reason for this turns out to be that Safari will otherwise announce that element as being a multinline element. We've seen this on an element with role=combobox, but it would be good to test whether this behavior happens with other roles too.

At least the following should pass axe-core:

<!-- This passes -->
<div aria-multiline="false" tabindex="0" aria-labelledby="foo" role="combobox" contenteditable>
@WilcoFiers WilcoFiers added fix Bug fixes rules Issue or false result from an axe-core rule support labels May 15, 2024
@WilcoFiers WilcoFiers added this to the Axe-core 4.10 milestone May 15, 2024
@straker
Copy link
Contributor

straker commented Jul 2, 2024

If there are more than one not allowed attr and some are falsey values and some are violations, we'll ignore the incomplete cases as to not report on false positives. Once the violations are resolved and there are no more to report on for the node, we'll report on the incomplete cases.

@WilcoFiers WilcoFiers changed the title aria-allowed-attr should incomplete attributes with a falsey value aria-allowed-attr ignore aria-multiline=false on element with contenteditable Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes rules Issue or false result from an axe-core rule support
Projects
None yet
2 participants