Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-required-children's reviewEmpty option is broken on hidden children #4010

Closed
WilcoFiers opened this issue May 8, 2023 · 0 comments · Fixed by #4012
Closed

aria-required-children's reviewEmpty option is broken on hidden children #4010

WilcoFiers opened this issue May 8, 2023 · 0 comments · Fixed by #4012
Labels
fix Bug fixes rules Issue or false result from an axe-core rule support

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented May 8, 2023

The following should be reported as incomplete of aria-required-children, rather than as a violation:

<div role="menu">
  <a href="#" role="menuitem" hidden>foo</a>
</div>

This bug was introduced in #3949, which told axe to ignore the roles of hidden children, but doesn't ignore hidden children when checking reviewEmpty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes rules Issue or false result from an axe-core rule support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant