Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(color-contrast): do not check contrast for inert elements #3894

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

straker
Copy link
Contributor

@straker straker commented Jan 25, 2023

Finishes the work on supporting inert. One question I have is if we want to not check the color contrast of labels (implicit, explicit, etc.) for inputs that are inerted. So this example:

<div id="t1"><span>Test</span></div>
<div role="textbox" aria-labelledby="bob t1 fred" inert></div>

We prevent checking this type of setup if the input is disabled (or aria-disabled). Do we need to do the same if the input has inert?

Closes: #3448

@straker straker requested a review from a team as a code owner January 25, 2023 21:46
@straker straker changed the title fix(color-contrast): do not check contrast on elements that are inerted fix(color-contrast): do not check contrast for inert elements Jan 25, 2023
@straker
Copy link
Contributor Author

straker commented Jan 26, 2023

We determined not to worry about inert inputs and their labels for now. If someone brings up an issue about it we'll reconsider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the HTML inert attribute
2 participants